public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfstests: require dedup ioctl support in 182
Date: Thu, 28 Jan 2016 11:27:53 -0800	[thread overview]
Message-ID: <20160128192753.GC20038@birch.djwong.org> (raw)
In-Reply-To: <1454001236-2600-3-git-send-email-hch@lst.de>

On Thu, Jan 28, 2016 at 06:13:54PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/182 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/182 b/tests/generic/182
> index bf5cd38..eb80b43 100755
> --- a/tests/generic/182
> +++ b/tests/generic/182
> @@ -46,6 +46,7 @@ _cleanup()
>  # real QA test starts here
>  _supported_os Linux
>  _require_test_reflink
> +_require_test_dedupe
>  _require_cp_reflink

The _require_*_reflink bits are unnecessary.  I must've been going too fast
when I wrote 181/182; I'll fix that in my repo and send patches.

Also 182's comments should s/reflink/dedupe/.

--D

>  
>  rm -f "$seqres.full"
> -- 
> 2.1.4
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-01-28 19:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 17:13 a couple xfstests fixes for reflinks Christoph Hellwig
2016-01-28 17:13 ` [PATCH 1/4] xfstests: fix scratch device filtering in 139 Christoph Hellwig
2016-01-28 19:24   ` Darrick J. Wong
2016-01-28 19:35     ` Darrick J. Wong
2016-01-28 17:13 ` [PATCH 2/4] xfstests: require dedup ioctl support in 182 Christoph Hellwig
2016-01-28 19:27   ` Darrick J. Wong [this message]
2016-01-28 17:13 ` [PATCH 3/4] xfstests: also treat EINVAL as reflink/dedup not supported Christoph Hellwig
2016-01-28 19:30   ` Darrick J. Wong
2016-01-28 17:13 ` [PATCH 4/4] xfstests: change to relative margins for reflinks tests Christoph Hellwig
2016-01-28 21:02 ` a couple xfstests fixes for reflinks Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128192753.GC20038@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=hch@lst.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox