From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfstests: also treat EINVAL as reflink/dedup not supported
Date: Thu, 28 Jan 2016 11:30:10 -0800 [thread overview]
Message-ID: <20160128193010.GD20038@birch.djwong.org> (raw)
In-Reply-To: <1454001236-2600-4-git-send-email-hch@lst.de>
On Thu, Jan 28, 2016 at 06:13:55PM +0100, Christoph Hellwig wrote:
> This can be returned by various implementations of the ioctl.
Looks reasonable, so
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> common/reflink | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/common/reflink b/common/reflink
> index de8e56d..8638aba 100644
> --- a/common/reflink
> +++ b/common/reflink
> @@ -92,6 +92,8 @@ _require_test_dedupe()
> _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> echo $testio | grep -q "Inappropriate ioctl for device" && \
> _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> + echo $testio | grep -q "Invalid argument" && \
> + _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> rm -rf "$TEST_DIR/file1" "$TEST_DIR/file2"
> }
>
> @@ -110,6 +112,8 @@ _require_scratch_dedupe()
> _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> echo $testio | grep -q "Inappropriate ioctl for device" && \
> _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> + echo $testio | grep -q "Invalid argument" && \
> + _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> _scratch_unmount
> }
>
> --
> 2.1.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-01-28 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 17:13 a couple xfstests fixes for reflinks Christoph Hellwig
2016-01-28 17:13 ` [PATCH 1/4] xfstests: fix scratch device filtering in 139 Christoph Hellwig
2016-01-28 19:24 ` Darrick J. Wong
2016-01-28 19:35 ` Darrick J. Wong
2016-01-28 17:13 ` [PATCH 2/4] xfstests: require dedup ioctl support in 182 Christoph Hellwig
2016-01-28 19:27 ` Darrick J. Wong
2016-01-28 17:13 ` [PATCH 3/4] xfstests: also treat EINVAL as reflink/dedup not supported Christoph Hellwig
2016-01-28 19:30 ` Darrick J. Wong [this message]
2016-01-28 17:13 ` [PATCH 4/4] xfstests: change to relative margins for reflinks tests Christoph Hellwig
2016-01-28 21:02 ` a couple xfstests fixes for reflinks Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128193010.GD20038@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox