From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfstests: fix scratch device filtering in 139
Date: Thu, 28 Jan 2016 11:35:06 -0800 [thread overview]
Message-ID: <20160128193506.GE20038@birch.djwong.org> (raw)
In-Reply-To: <20160128192446.GB20038@birch.djwong.org>
On Thu, Jan 28, 2016 at 11:24:46AM -0800, Darrick J. Wong wrote:
> On Thu, Jan 28, 2016 at 06:13:53PM +0100, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > tests/xfs/139 | 4 ++--
> > tests/xfs/139.out | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> > mode change 100644 => 100755 tests/xfs/139
> >
> > diff --git a/tests/xfs/139 b/tests/xfs/139
> > old mode 100644
> > new mode 100755
> > index 7400cf8..51c903e
> > --- a/tests/xfs/139
> > +++ b/tests/xfs/139
DOH ^^^
/me grabs another cup of coffee, tries again.
This patch is fine, ignore my earlier statements.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> > @@ -69,8 +69,8 @@ _pwrite_byte 0x62 0 $sz "$testdir/file1" >> "$seqres.full"
> > _scratch_remount
> >
> > echo "Compare files"
> > -md5sum "$testdir/file1" | _filter_test_dir
> > -md5sum "$testdir/file2" | _filter_test_dir
> > +md5sum "$testdir/file1" | _filter_scratch
> > +md5sum "$testdir/file2" | _filter_scratch
>
> This is fixed upstream.
>
> Well, the filtering was fixed and the test now runs on the test device
> and leaves scratchdev alone. :)
>
> --D
>
> > #filefrag -v "$testdir/file1" "$testdir/file2"
> >
> > echo "Check scratch fs"
> > diff --git a/tests/xfs/139.out b/tests/xfs/139.out
> > index 729e2d6..090e3af 100644
> > --- a/tests/xfs/139.out
> > +++ b/tests/xfs/139.out
> > @@ -3,6 +3,6 @@ Format and mount
> > Create the original files
> > CoW every other block
> > Compare files
> > -673c759fb131ccf3336c4f8c549a497e /opt/test-139/file1
> > -dc802351f6717547cbf4c951b294f952 /opt/test-139/file2
> > +673c759fb131ccf3336c4f8c549a497e SCRATCH_MNT/test-139/file1
> > +dc802351f6717547cbf4c951b294f952 SCRATCH_MNT/test-139/file2
> > Check scratch fs
> > --
> > 2.1.4
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-01-28 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 17:13 a couple xfstests fixes for reflinks Christoph Hellwig
2016-01-28 17:13 ` [PATCH 1/4] xfstests: fix scratch device filtering in 139 Christoph Hellwig
2016-01-28 19:24 ` Darrick J. Wong
2016-01-28 19:35 ` Darrick J. Wong [this message]
2016-01-28 17:13 ` [PATCH 2/4] xfstests: require dedup ioctl support in 182 Christoph Hellwig
2016-01-28 19:27 ` Darrick J. Wong
2016-01-28 17:13 ` [PATCH 3/4] xfstests: also treat EINVAL as reflink/dedup not supported Christoph Hellwig
2016-01-28 19:30 ` Darrick J. Wong
2016-01-28 17:13 ` [PATCH 4/4] xfstests: change to relative margins for reflinks tests Christoph Hellwig
2016-01-28 21:02 ` a couple xfstests fixes for reflinks Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128193506.GE20038@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox