Re: [PATCH] xfs: check sizes of XFS on-disk structures at compile time

Dave Chinner
2016-01-15T22:52:23Z

On Fri, Jan 15, 2016 at 12:58:01PM -0800, Darrick J. Wong wrote:
> On Mon, Jan 11, 2016 at 03:26:57PM -0800, Darrick J. Wong wrote:
> > Check the sizes of XFS on-disk structures when compiling the kernel.
> > Use this to catch inadvertent changes in structure size due to padding
> > and alignment issues, etc.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
....
> > + XFS_CHECK_STRUCT_SIZE(struct xfs_efi_log_format_64, 32);
> > + XFS_CHECK_STRUCT_SIZE(struct xfs_efd_log_format_32, 28);
> > + XFS_CHECK_STRUCT_SIZE(struct xfs_efd_log_format_64, 32);
> > + XFS_CHECK_STRUCT_SIZE(struct xfs_dq_logformat, 24);
> > + XFS_CHECK_STRUCT_SIZE(struct xfs_qoff_logformat, 20);
> > + XFS_CHECK_STRUCT_SIZE(struct xfs_icreate_log, 28);
> > +}
>
> Perhaps this huge function ought to hide away in its own file?

Yes, I think that's a good idea, and I think it should only be built
on debug builds, too.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com