Re: [PATCH] xfs: Split default quota limits by quota type V3

[Carlos Maiolino <cmaiolino@redhat.com>]

On Thu, Jan 28, 2016 at 11:36:55AM -0600, Eric Sandeen wrote:
> On 1/28/16 10:57 AM, Carlos Maiolino wrote:
> > Default quotas are globally set due historical reasons. IRIX only supported user
> > and project quotas, and default quota was only applied to user quotas.
> > 
> > In Linux, when a default quota is set, all different quota types inherits the
> > same default value.
> > 
> > An user with a quota limit larger than the default quota value, will still be
> > limited to the default value because the group quotas also inherits the default
> > quotas. Unless the group which the user belongs to have a custom quota limit
> > set.
> > 
> > This patch aims to split the default quota value by quota type. Allowing each
> > quota type having different default values.
> > 
> > Default time limits are still set globally. XFS does not set a per-user/group
> > timer, but a single global timer. For changing this behavior, some changes
> > should be made in user-space tools another bugs being fixed.
> 
> Some minor comments about comments below.  But the code looks fine to me,
> so:
> 
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> 
> and if you want to fix the comments & resend w/ my review tag I think that'd
> be ok.
> 
> Care to write an xfstests testcase for the default quota limit while you're
> at it?
> 
> Thanks,
> -Eric
> 
> > Changelog:
> > 
> > 	V2 - Remove comment about old behavior
> > 	V3 - Keep time limit configuration inside xfs_qm_init_quotainfo to keep
> > 	     the current behavior of quota timers
> > 
> > +	 *
> > +	 * Timers and warnings are globally set by the first timer found in
> > +	 * user/group/proj quota types, otherwise a default value is used.
> > +	 * This should be splitted into different fields per quota type.
> 
> s/splitted/split/
> 
> >  	 */
> >  	error = xfs_qm_dqread(mp, 0,
> >  			XFS_IS_UQUOTA_RUNNING(mp) ? XFS_DQ_USER :
> >  			 (XFS_IS_GQUOTA_RUNNING(mp) ? XFS_DQ_GROUP :
> >  			  XFS_DQ_PROJ),
> >  			XFS_QMOPT_DOWARN, &dqp);
> > +
> >  	if (!error) {
> >  		xfs_disk_dquot_t	*ddqp = &dqp->q_core;
> >  
> > -		/*
> > -		 * The warnings and timers set the grace period given to
> > -		 * a user or group before he or she can not perform any
> > -		 * more writing. If it is zero, a default is used.
> > -		 */
> 
> Not sure why you removed this comment?
> 
Regarding this comment, I think it's just redundant with the previous comment, I
left it in the code for the V4 though, I believe Dave can rip it off if it is
really redundant.

Cheers

-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs