From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Split default quota limits by quota type V3
Date: Tue, 2 Feb 2016 08:22:38 +1100 [thread overview]
Message-ID: <20160201212238.GV6033@dastard> (raw)
In-Reply-To: <20160201095707.GB8141@redhat.com>
On Mon, Feb 01, 2016 at 10:57:07AM +0100, Carlos Maiolino wrote:
> On Thu, Jan 28, 2016 at 11:36:55AM -0600, Eric Sandeen wrote:
> > On 1/28/16 10:57 AM, Carlos Maiolino wrote:
> > > xfs_disk_dquot_t *ddqp = &dqp->q_core;
> > >
> > > - /*
> > > - * The warnings and timers set the grace period given to
> > > - * a user or group before he or she can not perform any
> > > - * more writing. If it is zero, a default is used.
> > > - */
> >
> > Not sure why you removed this comment?
> >
> Regarding this comment, I think it's just redundant with the previous comment, I
> left it in the code for the V4 though, I believe Dave can rip it off if it is
> really redundant.
No, please don't ask me to do make random patch edits on commit -
it's your job as a patch submitter to get it right. I will sometimes
do this for simple patches or patches that come from a
never-seen-before-and-never-seen-again patch submitter, but for a
regular developer submitting non-trivial patches I won't change the
patches because the issue hasn't been sorted out during peer review.
Work it out with Eric, get a reviewed-by tag, and I'll apply it as
reviewed.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-01 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 16:57 [PATCH] xfs: Split default quota limits by quota type V3 Carlos Maiolino
2016-01-28 17:36 ` Eric Sandeen
2016-02-01 9:42 ` Carlos Maiolino
2016-02-01 9:57 ` Carlos Maiolino
2016-02-01 21:22 ` Dave Chinner [this message]
2016-02-02 14:22 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201212238.GV6033@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox