From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>, Christoph Hellwig <hch@lst.de>,
xfs@oss.sgi.com
Subject: Re: stop using ioends for direct write completions
Date: Tue, 2 Feb 2016 12:17:40 +0100 [thread overview]
Message-ID: <20160202111740.GA28777@lst.de> (raw)
In-Reply-To: <20160201215407.GI20038@birch.djwong.org>
On Mon, Feb 01, 2016 at 01:54:07PM -0800, Darrick J. Wong wrote:
> Also: I've noticed that if I write 8MB file to a file backed by a failing
> device, xfs_end_io_direct_write() gets called with size == 8MB even if the
> writes failed. If the write was to an unwritten extent, the extent will be
> converted to a regular extent even though the blocks contain old file contents
> and other garbage, which can subsequently be read off the disk.
>
> For CoW I'd only want to remap the blocks if the write totally succeeds. If a
> disk error happens, the EIO code gets passed back to userspace, and it seems
> logical to me that the file contents should remain unchanged.
>
> To that end, I'm changing dio_iodone_t to pass an error code, and I think I
> want to change XFS to avoid doing unwritten extent conversions when the write
> fails. Does that make sense?
I have some of these patches prepared already, I'm just too busy keeping
up with all your changes. I'll rebase and post this ASAP!
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-02 11:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 10:10 stop using ioends for direct write completions Christoph Hellwig
2016-01-14 10:10 ` [PATCH] xfs: don't use " Christoph Hellwig
2016-01-28 13:16 ` stop using " Christoph Hellwig
2016-01-28 20:53 ` Darrick J. Wong
2016-01-28 21:10 ` Christoph Hellwig
2016-01-28 21:58 ` Darrick J. Wong
2016-01-28 22:02 ` Christoph Hellwig
2016-01-28 22:31 ` Darrick J. Wong
2016-01-29 8:01 ` Christoph Hellwig
2016-01-29 14:12 ` Brian Foster
2016-02-01 21:54 ` Darrick J. Wong
2016-02-02 11:17 ` Christoph Hellwig [this message]
2016-02-02 15:26 ` Brian Foster
2016-02-02 11:20 ` Christoph Hellwig
2016-02-02 15:31 ` Brian Foster
2016-02-02 16:42 ` Christoph Hellwig
2016-02-03 22:22 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202111740.GA28777@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox