From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
xfs@oss.sgi.com, Christoph Hellwig <hch@lst.de>,
darrick.wong@oracle.com
Subject: Re: stop using ioends for direct write completions
Date: Tue, 2 Feb 2016 12:20:46 +0100 [thread overview]
Message-ID: <20160202112046.GB28777@lst.de> (raw)
In-Reply-To: <20160129141232.GA43184@bfoster.bfoster>
On Fri, Jan 29, 2016 at 09:12:33AM -0500, Brian Foster wrote:
> My understanding is that the original requirement for ioends here was to
> track the state necessary in order to defer (to wq) completions that had
> to allocate transactions. Eventually, the deferred buffer state was
> implemented and we no longer required an ioend for that, so we removed
> the ioends here:
>
> 2ba6623 xfs: don't allocate an ioend for direct I/O completions
>
> Then just a couple months later, we merged the following to re-add the
> ioend into the dio path:
>
> d5cc2e3f xfs: DIO needs an ioend for writes
And I complained about that one! I didn't have time to provide a full
analysis and the patches around this one were criticial enough. But this
patch has the analysis on why ioends are not needed and bad which should
have been the full review back then. Note that this new version is
better than the old ioend removal as it does not just use the private
data as a boolean, but as a bitmask so that additional information
such as the COW status can be communicated.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-02 11:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 10:10 stop using ioends for direct write completions Christoph Hellwig
2016-01-14 10:10 ` [PATCH] xfs: don't use " Christoph Hellwig
2016-01-28 13:16 ` stop using " Christoph Hellwig
2016-01-28 20:53 ` Darrick J. Wong
2016-01-28 21:10 ` Christoph Hellwig
2016-01-28 21:58 ` Darrick J. Wong
2016-01-28 22:02 ` Christoph Hellwig
2016-01-28 22:31 ` Darrick J. Wong
2016-01-29 8:01 ` Christoph Hellwig
2016-01-29 14:12 ` Brian Foster
2016-02-01 21:54 ` Darrick J. Wong
2016-02-02 11:17 ` Christoph Hellwig
2016-02-02 15:26 ` Brian Foster
2016-02-02 11:20 ` Christoph Hellwig [this message]
2016-02-02 15:31 ` Brian Foster
2016-02-02 16:42 ` Christoph Hellwig
2016-02-03 22:22 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202112046.GB28777@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox