From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Brian Foster <bfoster@redhat.com>,
xfs@oss.sgi.com, darrick.wong@oracle.com
Subject: Re: stop using ioends for direct write completions
Date: Thu, 4 Feb 2016 09:22:16 +1100 [thread overview]
Message-ID: <20160203222216.GG459@dastard> (raw)
In-Reply-To: <20160202164237.GA25436@lst.de>
On Tue, Feb 02, 2016 at 05:42:37PM +0100, Christoph Hellwig wrote:
> On Tue, Feb 02, 2016 at 10:31:18AM -0500, Brian Foster wrote:
> > FWIW, I don't see any such review comments against the three versions of
> > the "DIO needs an ioend for writes" patch I have in my mailbox, but I
> > easily could have missed something..? But if there wasn't time, then
> > fair enough.
>
> I'll have to look at the mailboxes, but I remember Dave sending this
> out and complaining.
I don't recall the exact discussion that was had, but at the time it
was an evil that I couldn't see a way of avoiding, and with no other
solution being presented.
ISTR a tie-in with the DAX code, too, but that's gone away now with
the block zeroing during allocation rather than using unwritten
extents and completions for this.
> > If COW is the primary motivator, perhaps we can bundle it with that
> > work?
>
> The prime motivator is to:
>
> (1) avoid a pointless memory allocation
> (2) avoid a pointless context switch
> (3) avoid pointless code complexity
>
> COW is just another case where these show up.
*nod*
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-02-03 22:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 10:10 stop using ioends for direct write completions Christoph Hellwig
2016-01-14 10:10 ` [PATCH] xfs: don't use " Christoph Hellwig
2016-01-28 13:16 ` stop using " Christoph Hellwig
2016-01-28 20:53 ` Darrick J. Wong
2016-01-28 21:10 ` Christoph Hellwig
2016-01-28 21:58 ` Darrick J. Wong
2016-01-28 22:02 ` Christoph Hellwig
2016-01-28 22:31 ` Darrick J. Wong
2016-01-29 8:01 ` Christoph Hellwig
2016-01-29 14:12 ` Brian Foster
2016-02-01 21:54 ` Darrick J. Wong
2016-02-02 11:17 ` Christoph Hellwig
2016-02-02 15:26 ` Brian Foster
2016-02-02 11:20 ` Christoph Hellwig
2016-02-02 15:31 ` Brian Foster
2016-02-02 16:42 ` Christoph Hellwig
2016-02-03 22:22 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203222216.GG459@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox