* [PATCH] dax: dirty inode only if required
@ 2016-02-04 14:02 Dmitry Monakhov
2016-02-04 14:33 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Monakhov @ 2016-02-04 14:02 UTC (permalink / raw)
To: Ross Zwisler
Cc: X86 ML, Theodore Ts'o, Andrew Morton,
linux-nvdimm@lists.01.org, Jan Kara, linux-kernel@vger.kernel.org,
Dave Hansen, XFS Developers, J. Bruce Fields, Linux MM,
Ingo Molnar, Andreas Dilger, Alexander Viro, H. Peter Anvin,
linux-fsdevel, Matthew Wilcox, Jeff Layton, linux-ext4,
Thomas Gleixner, Matthew Wilcox
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/dax.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/dax.c b/fs/dax.c
index e0e9358..fc2e314 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
void *entry;
WARN_ON_ONCE(pmd_entry && !dirty);
- __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
+ if (dirty)
+ __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
spin_lock_irq(&mapping->tree_lock);
--
1.8.3.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dax: dirty inode only if required
2016-02-04 14:02 [PATCH] dax: dirty inode only if required Dmitry Monakhov
@ 2016-02-04 14:33 ` Jan Kara
2016-02-04 15:50 ` Ross Zwisler
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2016-02-04 14:33 UTC (permalink / raw)
To: Dmitry Monakhov
Cc: Dave Hansen, J. Bruce Fields, Linux MM, Andreas Dilger,
H. Peter Anvin, Jeff Layton, linux-nvdimm@lists.01.org, X86 ML,
Ingo Molnar, Matthew Wilcox, Ross Zwisler, linux-ext4,
XFS Developers, Alexander Viro, Thomas Gleixner,
Theodore Ts'o, linux-kernel@vger.kernel.org, Jan Kara,
linux-fsdevel, Andrew Morton, Matthew Wilcox
On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Makes sense. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/dax.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index e0e9358..fc2e314 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> void *entry;
>
> WARN_ON_ONCE(pmd_entry && !dirty);
> - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> + if (dirty)
> + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
>
> spin_lock_irq(&mapping->tree_lock);
>
> --
> 1.8.3.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dax: dirty inode only if required
2016-02-04 14:33 ` Jan Kara
@ 2016-02-04 15:50 ` Ross Zwisler
0 siblings, 0 replies; 3+ messages in thread
From: Ross Zwisler @ 2016-02-04 15:50 UTC (permalink / raw)
To: Jan Kara
Cc: Dave Hansen, J. Bruce Fields, Linux MM, Andreas Dilger,
H. Peter Anvin, Jeff Layton, linux-nvdimm@lists.01.org, X86 ML,
Ingo Molnar, Matthew Wilcox, Ross Zwisler, linux-ext4,
XFS Developers, Alexander Viro, Thomas Gleixner,
Theodore Ts'o, linux-kernel@vger.kernel.org, Dmitry Monakhov,
Jan Kara, linux-fsdevel, Andrew Morton, Matthew Wilcox
On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote:
> On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> >
> > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
> Makes sense. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Looks good to me as well.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Honza
> > ---
> > fs/dax.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index e0e9358..fc2e314 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> > void *entry;
> >
> > WARN_ON_ONCE(pmd_entry && !dirty);
> > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> > + if (dirty)
> > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> >
> > spin_lock_irq(&mapping->tree_lock);
> >
> > --
> > 1.8.3.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-04 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-04 14:02 [PATCH] dax: dirty inode only if required Dmitry Monakhov
2016-02-04 14:33 ` Jan Kara
2016-02-04 15:50 ` Ross Zwisler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox