From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 616CC7CA9 for ; Mon, 8 Feb 2016 03:42:42 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id EC7C6AC001 for ; Mon, 8 Feb 2016 01:42:41 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id oOuDub8BHT3ophS6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Mon, 08 Feb 2016 01:42:40 -0800 (PST) Date: Mon, 8 Feb 2016 01:42:39 -0800 From: Christoph Hellwig Subject: Re: [PATCH 9/9] xfs: mode di_mode to vfs inode Message-ID: <20160208094239.GD4487@infradead.org> References: <1454905461-2773-1-git-send-email-david@fromorbit.com> <1454905461-2773-10-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1454905461-2773-10-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, Feb 08, 2016 at 03:24:21PM +1100, Dave Chinner wrote: > - ASSERT(!(S_ISREG(ip->i_d.di_mode) && whichfork == XFS_DATA_FORK)); > + ASSERT(!(S_ISREG(VFS_I(ip)->i_mode) && whichfork == XFS_DATA_FORK)); Maybe it's worth adding XFS_ISDIR/REG/.. helpers for all these checks? Otherwise looks fine: Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs