Re: [PATCH 9/9] xfs: mode di_mode to vfs inode

Christoph Hellwig
2016-02-08T09:42:42Z

On Mon, Feb 08, 2016 at 03:24:21PM +1100, Dave Chinner wrote:
> - ASSERT(!(S_ISREG(ip->i_d.di_mode) && whichfork == XFS_DATA_FORK));
> + ASSERT(!(S_ISREG(VFS_I(ip)->i_mode) && whichfork == XFS_DATA_FORK));

Maybe it's worth adding XFS_ISDIR/REG/.. helpers for all these checks?

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>