Re: [PATCH 12/23] xfs/122: support refcount/rmap data structures

Darrick J. Wong
2016-02-09T07:55:18Z

On Tue, Feb 09, 2016 at 06:43:30PM +1100, Dave Chinner wrote:
> On Mon, Feb 08, 2016 at 05:13:03PM -0800, Darrick J. Wong wrote:
> > Include the refcount and rmap structures in the golden output.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tests/xfs/122 | 3 +++
> > tests/xfs/122.out | 4 ++++
> > tests/xfs/group | 2 +-
> > 3 files changed, 8 insertions(+), 1 deletion(-)
> >
> >
> > diff --git a/tests/xfs/122 b/tests/xfs/122
> > index e6697a2..758cb50 100755
> > --- a/tests/xfs/122
> > +++ b/tests/xfs/122
> > @@ -90,6 +90,9 @@ xfs_da3_icnode_hdr
> > xfs_dir3_icfree_hdr
> > xfs_dir3_icleaf_hdr
> > xfs_name
> > +xfs_owner_info
> > +xfs_refcount_irec
> > +xfs_rmap_irec
> > xfs_alloctype_t
> > xfs_buf_cancel_t
> > xfs_bmbt_rec_32_t
>
> So this is going to cause failures on any userspace that doesn't
> know about these new types, right?
>
> Should these be conditional in some way?

I wasn't sure how to handle this -- I could just keep the patch at the head of
my stack (unreleased) until xfsprogs pulls in the appropriate libxfs pieces?
So long as we're not dead certain of the final format of the rmapbt and
refcountbt, there's probably not a lot of value in putting this in (yet).

--D

>
> Cheers,
>
> Dave.
>
> --
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html