From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/6] xfs: rename XFS_BUF_ZEROFLAGS macro
Date: Wed, 10 Feb 2016 08:23:36 +1100 [thread overview]
Message-ID: <20160209212336.GB14668@dastard> (raw)
In-Reply-To: <20160209091632.GB23349@infradead.org>
On Tue, Feb 09, 2016 at 01:16:32AM -0800, Christoph Hellwig wrote:
> On Tue, Feb 09, 2016 at 09:31:20AM +1100, Dave Chinner wrote:
> > > xlog_sync already sets a lot of these flags again, and is called on an
> > > iclog buffer which never has the READ or XBF_WRITE_FAIL set, so just
> > > replacing it with an opencoded
> > >
> > > bp->b_flags &= (XBF_FUA | XBF_FLUSH);
> >
> > We can't do that because there are internal flags like _XBF_PAGES
> > that are set on log buffers. Clearing such flags will cause problems
> > when the iclog buffer is finally released on unmount. Hence I'd
> > prefer to keep the code as it stands.
>
> Sorry - meabt to write:
>
> bp->b_flags &= ~(XBF_FUA | XBF_FLUSH);
>
> which is all we'll need. All other flags cleared by XFS_BUF_ZEROFLAGS
> are either never set for log buffers (XBF_READ, XBF_WRITE_FAIL), or
> always set for log buffers (XBF_WRITE, XBF_ASYNC, XBF_SYNCIO).
Ah, that makes more sense. I should have realised that, but there
are places where we do clear buffer flags like your original
suggestion so it didn't occur to me it was just a typo. I'll fix it
up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-09 21:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 0:37 [PATCH 0/6] xfs: clean up buffer flag macros Dave Chinner
2016-02-05 0:37 ` [PATCH 1/6] xfs: remove XBF_DONE flag wrapper macros Dave Chinner
2016-02-08 9:04 ` Christoph Hellwig
2016-02-05 0:37 ` [PATCH 2/6] xfs: remove XBF_ASYNC " Dave Chinner
2016-02-08 9:05 ` Christoph Hellwig
2016-02-05 0:38 ` [PATCH 3/6] xfs: remove XBF_READ " Dave Chinner
2016-02-08 9:05 ` Christoph Hellwig
2016-02-05 0:38 ` [PATCH 4/6] xfs: remove XBF_WRITE " Dave Chinner
2016-02-08 9:06 ` Christoph Hellwig
2016-02-05 0:38 ` [PATCH 5/6] xfs: remove XBF_STALE " Dave Chinner
2016-02-08 9:07 ` Christoph Hellwig
2016-02-05 0:38 ` [PATCH 6/6] xfs: rename XFS_BUF_ZEROFLAGS macro Dave Chinner
2016-02-08 9:12 ` Christoph Hellwig
2016-02-08 22:31 ` Dave Chinner
2016-02-08 22:59 ` [PATCH 6/6 v2] " Dave Chinner
2016-02-09 9:16 ` [PATCH 6/6] " Christoph Hellwig
2016-02-09 21:23 ` Dave Chinner [this message]
2016-02-09 21:38 ` [PATCH 6/6 v3] xfs: remove " Dave Chinner
2016-02-09 21:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209212336.GB14668@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox