From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] xfs: don't chain ioends during writepage submission
Date: Wed, 10 Feb 2016 08:52:40 +1100 [thread overview]
Message-ID: <20160209215240.GG14668@dastard> (raw)
In-Reply-To: <20160209134930.GD13357@infradead.org>
On Tue, Feb 09, 2016 at 05:49:30AM -0800, Christoph Hellwig wrote:
> > +STATIC struct xfs_ioend *
> > xfs_add_to_ioend(
> > struct inode *inode,
> > struct buffer_head *bh,
> > xfs_off_t offset,
> > struct xfs_writepage_ctx *wpc)
> > {
> > + struct xfs_ioend *ioend_to_submit = NULL;
>
> Maybe just
>
> struct xfs_ioend *prev = NULL;
>
> to be a little less verbose?
*nod*
> > + if (wpc->ioend)
> > + xfs_submit_ioend(wbc, wpc->ioend, status);
> > return status;
> > }
>
> With this change xfs_writepage_submit is rather pointless, I'd
> rather open code it in the callers.
Yup.
>
> > + ioend = xfs_add_to_ioend(inode, bh, offset, wpc);
> > + if (ioend) {
> > + ioend->io_list = NULL;
> > + if (!ioend_to_submit)
> > + ioend_to_submit = ioend;
> > + else
> > + ioend_tail->io_list = ioend;
> > + ioend_tail = ioend;
> > + }
>
> Just using a list_head for this is a lot easier to read and less
> error prone at the cost of a single additional pointer in the ioend.
OK. I'll see what I can do here.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-09 21:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 5:44 [PATCH 0/5 v3] xfs: get rid of xfs_cluster_write() Dave Chinner
2016-02-08 5:44 ` [PATCH 1/5] xfs: remove nonblocking mode from xfs_vm_writepage Dave Chinner
2016-02-08 5:44 ` [PATCH 2/5] xfs: Introduce writeback context for writepages Dave Chinner
2016-02-09 13:39 ` Christoph Hellwig
2016-02-09 21:48 ` Dave Chinner
2016-02-09 23:16 ` Dave Chinner
2016-02-09 14:22 ` Brian Foster
2016-02-09 21:51 ` Dave Chinner
2016-02-08 5:44 ` [PATCH 3/5] xfs: xfs_cluster_write is redundant Dave Chinner
2016-02-09 13:40 ` Christoph Hellwig
2016-02-08 5:44 ` [PATCH 4/5] xfs: factor mapping out of xfs_do_writepage Dave Chinner
2016-02-09 13:40 ` Christoph Hellwig
2016-02-08 5:44 ` [PATCH 5/5] xfs: don't chain ioends during writepage submission Dave Chinner
2016-02-09 13:49 ` Christoph Hellwig
2016-02-09 21:52 ` Dave Chinner [this message]
2016-02-09 14:23 ` Brian Foster
2016-02-09 21:59 ` Dave Chinner
2016-02-10 13:18 ` Brian Foster
2016-02-10 21:09 ` Dave Chinner
2016-02-11 12:24 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209215240.GG14668@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox