Re: [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write

Dave Chinner
2016-02-11T20:14:58Z

On Thu, Feb 11, 2016 at 07:13:01AM -0800, Christoph Hellwig wrote:
> On Thu, Feb 11, 2016 at 08:25:51AM +1100, Dave Chinner wrote:
> > I really like the idea, especially how using a bioset encapsulates
> > the ioend and binds the life cycle to the bio. It also removes a
> > heap of code, too.
> >
> > We really do need some form of chaining here, though. If we don't,
> > then we'll be doing unwritten extent of set file size transactions
> > for ever 1MB bio completion instead of once for however large
> > writepages can build an ioend.
> >
> > I think this is definitely worth pursuing - are you going to get any
> > time to work on this in the next couple of months, Christoph (i.e.
> > to target the 4.7 merge window)?
>
> Yes, I've just started working on this and would love to get it off
> my table ASAP. I was doing this ontop of your initial writeback
> changes, so let me know if I should go back to that version, or
> you think the last two patches will be ready in time as well?

Keep my extra two patches in your series. I'm going to try to spend
the rest of this cycle (for the 4.6 merge window) on Darrick's
reflink patchset, but I can carry whatever patches you finish off
until the appropriate time to merge them is.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com