Re: [PATCH 2/8] xfs: remove xfs_cancel_ioend

Christoph Hellwig
2016-02-10T11:28:06Z

> +static int
> +xfs_writepage_submit(
> + struct xfs_ioend *ioend,
> + struct xfs_ioend *iohead,
> + struct writeback_control *wbc,
> + int status)
> +{
> + struct blk_plug plug;
> +
> + /* Reserve log space if we might write beyond the on-disk inode size. */
> + if (!status && ioend && ioend->io_type != XFS_IO_UNWRITTEN &&
> + xfs_ioend_is_append(ioend))
> + status = xfs_setfilesize_trans_alloc(ioend);
> +
> + if (iohead) {
> + blk_start_plug(&plug);
> + xfs_submit_ioend(wbc, iohead, status);
> + blk_finish_plug(&plug);
> + }
> + return status;
> +}

We return the xfs_setfilesize_trans_alloc failure status here,
but none of the callers pick it up. The way this is handled later
changes a bit, but even at the end of the series only 1 of the
three callers handles the error.