From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write
Date: Thu, 11 Feb 2016 08:25:51 +1100 [thread overview]
Message-ID: <20160210212550.GM14668@dastard> (raw)
In-Reply-To: <20160210182538.GA7481@infradead.org>
On Wed, Feb 10, 2016 at 10:25:38AM -0800, Christoph Hellwig wrote:
> On Wed, Feb 10, 2016 at 07:47:15PM +1100, Dave Chinner wrote:
> > of the writepage context. Patches 7 and 8 are new patches (as in the
> > first time I've posted them) to demonstrate how to remove the IO
> > completion dependency on recording the bufferehads attached to the
> > ioend. This is the first step in removing bufferheads from the
> > writepage IO path - these are FYI patches, not patches I want to
> > have committed immediately.
>
> This looks interesting. I played around with this a bit and ported
> my patch to embedd the main bio into struct ioend to it. My older
> version allowed to chain additional bios to get ioends larger than
> 1MB (or PAGE_SIZE * 256), but that will require additional work
> in the new completion handler. It does however simplify things quite
> a bit, and I suspect a lot of that simplification could be kept even
> with chained bios. I've attached the patch below for reference:
I really like the idea, especially how using a bioset encapsulates
the ioend and binds the life cycle to the bio. It also removes a
heap of code, too.
We really do need some form of chaining here, though. If we don't,
then we'll be doing unwritten extent of set file size transactions
for ever 1MB bio completion instead of once for however large
writepages can build an ioend.
I think this is definitely worth pursuing - are you going to get any
time to work on this in the next couple of months, Christoph (i.e.
to target the 4.7 merge window)?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-10 21:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 8:47 [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write Dave Chinner
2016-02-10 8:47 ` [PATCH 1/8] xfs: remove nonblocking mode from xfs_vm_writepage Dave Chinner
2016-02-10 8:47 ` [PATCH 2/8] xfs: remove xfs_cancel_ioend Dave Chinner
2016-02-10 11:28 ` Christoph Hellwig
2016-02-11 0:21 ` Dave Chinner
2016-02-11 15:14 ` Christoph Hellwig
2016-02-11 20:59 ` Dave Chinner
2016-02-10 8:47 ` [PATCH 3/8] xfs: Introduce writeback context for writepages Dave Chinner
2016-02-10 11:31 ` Christoph Hellwig
2016-02-11 0:25 ` Dave Chinner
2016-02-10 8:47 ` [PATCH 4/8] xfs: xfs_cluster_write is redundant Dave Chinner
2016-02-10 8:47 ` [PATCH 5/8] xfs: factor mapping out of xfs_do_writepage Dave Chinner
2016-02-10 8:47 ` [PATCH 6/8] xfs: don't chain ioends during writepage submission Dave Chinner
2016-02-10 11:36 ` Christoph Hellwig
2016-02-11 0:26 ` Dave Chinner
2016-02-11 6:39 ` Dave Chinner
2016-02-10 8:47 ` [PATCH 7/8] [RFC] xfs: build bios directly in xfs_add_to_ioend Dave Chinner
2016-02-10 8:47 ` [PATCH 8/8] [RFC] xfs: don't release bios on completion immediately Dave Chinner
2016-02-10 9:05 ` [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write Christoph Hellwig
2016-02-10 18:25 ` Christoph Hellwig
2016-02-10 21:25 ` Dave Chinner [this message]
2016-02-11 15:13 ` Christoph Hellwig
2016-02-11 20:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210212550.GM14668@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox