From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/8] xfs: Introduce writeback context for writepages
Date: Thu, 11 Feb 2016 11:25:44 +1100 [thread overview]
Message-ID: <20160211002544.GS14668@dastard> (raw)
In-Reply-To: <20160210113126.GB15221@infradead.org>
On Wed, Feb 10, 2016 at 03:31:26AM -0800, Christoph Hellwig wrote:
> > + struct xfs_writepage_ctx wpc = {
> > + .io_type = XFS_IO_OVERWRITE,
> > + };
> > + int ret;
> > +
> > + ret = xfs_do_writepage(page, wbc, &wpc);
> > + return xfs_writepage_submit(&wpc, wbc, ret);
> > +}
> > +
> > +STATIC int
> > xfs_vm_writepages(
> > struct address_space *mapping,
> > struct writeback_control *wbc)
> > {
> > + struct xfs_writepage_ctx wpc = {
> > + .io_type = XFS_IO_OVERWRITE,
> > + };
>
> Shouldn't we start out with an invalid (0) state, and just move
> the actual states up to start from 1?
This is just a translation of the existing code - the imap_valid
flag being initialised to zero ensures the io_type is correctly
initialised if it differs from XFS_IO_OVERWRITE. I guess there's no
harm in changing it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-11 0:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 8:47 [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write Dave Chinner
2016-02-10 8:47 ` [PATCH 1/8] xfs: remove nonblocking mode from xfs_vm_writepage Dave Chinner
2016-02-10 8:47 ` [PATCH 2/8] xfs: remove xfs_cancel_ioend Dave Chinner
2016-02-10 11:28 ` Christoph Hellwig
2016-02-11 0:21 ` Dave Chinner
2016-02-11 15:14 ` Christoph Hellwig
2016-02-11 20:59 ` Dave Chinner
2016-02-10 8:47 ` [PATCH 3/8] xfs: Introduce writeback context for writepages Dave Chinner
2016-02-10 11:31 ` Christoph Hellwig
2016-02-11 0:25 ` Dave Chinner [this message]
2016-02-10 8:47 ` [PATCH 4/8] xfs: xfs_cluster_write is redundant Dave Chinner
2016-02-10 8:47 ` [PATCH 5/8] xfs: factor mapping out of xfs_do_writepage Dave Chinner
2016-02-10 8:47 ` [PATCH 6/8] xfs: don't chain ioends during writepage submission Dave Chinner
2016-02-10 11:36 ` Christoph Hellwig
2016-02-11 0:26 ` Dave Chinner
2016-02-11 6:39 ` Dave Chinner
2016-02-10 8:47 ` [PATCH 7/8] [RFC] xfs: build bios directly in xfs_add_to_ioend Dave Chinner
2016-02-10 8:47 ` [PATCH 8/8] [RFC] xfs: don't release bios on completion immediately Dave Chinner
2016-02-10 9:05 ` [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write Christoph Hellwig
2016-02-10 18:25 ` Christoph Hellwig
2016-02-10 21:25 ` Dave Chinner
2016-02-11 15:13 ` Christoph Hellwig
2016-02-11 20:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211002544.GS14668@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox