From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/8] xfs: remove xfs_cancel_ioend
Date: Fri, 12 Feb 2016 07:59:16 +1100 [thread overview]
Message-ID: <20160211205916.GK19486@dastard> (raw)
In-Reply-To: <20160211151425.GB13515@infradead.org>
On Thu, Feb 11, 2016 at 07:14:25AM -0800, Christoph Hellwig wrote:
> On Thu, Feb 11, 2016 at 11:21:37AM +1100, Dave Chinner wrote:
> > I'll propagate it through where it makes sense. If we alrady have an
> > error, then we aren't going to call xfs_setfilesize_trans_alloc()
> > anyway, so checking the return value only matters in the non-error
> > cases.
>
> Oh, I missed that we don't care about the failure case. Maybe we
> should just call xfs_setfilesize_trans_alloc instead, and just move
> the conditionals to it so that it's a no-op if no transaction is needed?
OK, but let's make cleanups like this at the start of the next
batch of work we are already working on for this code so this can be
finalised and made available for wider testing....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-11 20:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 8:47 [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write Dave Chinner
2016-02-10 8:47 ` [PATCH 1/8] xfs: remove nonblocking mode from xfs_vm_writepage Dave Chinner
2016-02-10 8:47 ` [PATCH 2/8] xfs: remove xfs_cancel_ioend Dave Chinner
2016-02-10 11:28 ` Christoph Hellwig
2016-02-11 0:21 ` Dave Chinner
2016-02-11 15:14 ` Christoph Hellwig
2016-02-11 20:59 ` Dave Chinner [this message]
2016-02-10 8:47 ` [PATCH 3/8] xfs: Introduce writeback context for writepages Dave Chinner
2016-02-10 11:31 ` Christoph Hellwig
2016-02-11 0:25 ` Dave Chinner
2016-02-10 8:47 ` [PATCH 4/8] xfs: xfs_cluster_write is redundant Dave Chinner
2016-02-10 8:47 ` [PATCH 5/8] xfs: factor mapping out of xfs_do_writepage Dave Chinner
2016-02-10 8:47 ` [PATCH 6/8] xfs: don't chain ioends during writepage submission Dave Chinner
2016-02-10 11:36 ` Christoph Hellwig
2016-02-11 0:26 ` Dave Chinner
2016-02-11 6:39 ` Dave Chinner
2016-02-10 8:47 ` [PATCH 7/8] [RFC] xfs: build bios directly in xfs_add_to_ioend Dave Chinner
2016-02-10 8:47 ` [PATCH 8/8] [RFC] xfs: don't release bios on completion immediately Dave Chinner
2016-02-10 9:05 ` [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write Christoph Hellwig
2016-02-10 18:25 ` Christoph Hellwig
2016-02-10 21:25 ` Dave Chinner
2016-02-11 15:13 ` Christoph Hellwig
2016-02-11 20:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211205916.GK19486@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox