Re: [PATCH 12/32] dio: unwritten conversion bug tests

Theodore Ts'o
2016-02-12T15:22:43Z

On Fri, Feb 12, 2016 at 02:52:53PM +1100, Dave Chinner wrote:
> On Thu, Feb 11, 2016 at 03:40:37PM -0800, Darrick J. Wong wrote:
> > Check that we don't expose old disk contents when a directio write to
> > an unwritten extent fails due to IO errors. This primarily affects
> > XFS and ext4.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> aiocp.c: In function 'main':
> aiocp.c:407:1: warning: format '%d' expects argument of type 'int', but argument 3 has type 'off_t' [-Wformat=]
> printf("tocopy=%d len=%d blk=%d\n", tocopy, length, aio_blksize);
> ^
>
> Followup patch is fine, I'll commit as is.

Dave, given that Darrick's patches is going to cause more
_scratch_mount occurences, how quickly do you plan to commit his
patchset? Should I wait until he makes his change before I do the
s/_scratch_mount/_scratch_cycle_mount/ change? Should I make that
change, and let you fix it up the commit?

Thanks,

- Ted