From: Christoph Hellwig <hch@infradead.org>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: stable@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths
Date: Fri, 12 Feb 2016 01:27:35 -0800 [thread overview]
Message-ID: <20160212092735.GA27496@infradead.org> (raw)
In-Reply-To: <1455129337-19255-1-git-send-email-mguzik@redhat.com>
On Wed, Feb 10, 2016 at 07:35:37PM +0100, Mateusz Guzik wrote:
> This plugs 2 trivial leaks in xfs_attr_shortform_list and
> xfs_attr3_leaf_list_int.
Can you please add a out: label before the kmem_free at the end of
the function, return the actual error value there and make all others
returns after the kmem_alloc jump to that label?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-02-12 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 18:35 [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths Mateusz Guzik
2016-02-10 20:38 ` Eric Sandeen
2016-02-12 9:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212092735.GA27496@infradead.org \
--to=hch@infradead.org \
--cc=mguzik@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox