From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/6] xfs: don't chain ioends during writepage submission
Date: Fri, 12 Feb 2016 01:36:07 -0800 [thread overview]
Message-ID: <20160212093607.GB4633@infradead.org> (raw)
In-Reply-To: <1455173146-19535-7-git-send-email-david@fromorbit.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tiny nitpick below:
> out_error:
> /*
Now that the code below this label is more than just error handling
it might make sense to rename it to just 'out'.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-02-12 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 6:45 [PATCH 0/6 v5] xfs: get rid of xfs_cluster_write() Dave Chinner
2016-02-11 6:45 ` [PATCH 1/6] xfs: remove nonblocking mode from xfs_vm_writepage Dave Chinner
2016-02-11 6:45 ` [PATCH 2/6] xfs: remove xfs_cancel_ioend Dave Chinner
2016-02-12 9:30 ` Christoph Hellwig
2016-02-11 6:45 ` [PATCH 3/6] xfs: Introduce writeback context for writepages Dave Chinner
2016-02-11 6:45 ` [PATCH 4/6] xfs: xfs_cluster_write is redundant Dave Chinner
2016-02-11 6:45 ` [PATCH 5/6] xfs: factor mapping out of xfs_do_writepage Dave Chinner
2016-02-11 6:45 ` [PATCH 6/6] xfs: don't chain ioends during writepage submission Dave Chinner
2016-02-12 9:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212093607.GB4633@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox