From: Brian Foster <bfoster@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix format specifier , should be %llx and not %llu
Date: Mon, 15 Feb 2016 13:57:23 -0500 [thread overview]
Message-ID: <20160215185723.GE33291@bfoster.bfoster> (raw)
In-Reply-To: <1455395182-4771-1-git-send-email-colin.king@canonical.com>
On Sat, Feb 13, 2016 at 08:26:22PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> busyp->bno is printed with a %llu format specifier when the
> intention is to print a hexadecimal value. Trivial fix to
> use %llx instead. Found with smatch static analysis:
>
> fs/xfs/xfs_discard.c:229 xfs_discard_extents() warn: '0x'
> prefix is confusing together with '%llu' specifier
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_discard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index e85a951..272c3f8 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -227,7 +227,7 @@ xfs_discard_extents(
> GFP_NOFS, 0);
> if (error && error != -EOPNOTSUPP) {
> xfs_info(mp,
> - "discard failed for extent [0x%llu,%u], error %d",
> + "discard failed for extent [0x%llx,%u], error %d",
> (unsigned long long)busyp->bno,
> busyp->length,
> error);
> --
> 2.7.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-02-15 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 20:26 [PATCH] xfs: fix format specifier , should be %llx and not %llu Colin King
2016-02-15 18:57 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215185723.GE33291@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox