From: Dave Chinner <david@fromorbit.com>
To: Alex Lyakas <alex@zadarastorage.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Danny Shavit <danny@zadarastorage.com>,
Shyam Kaushik <shyam@zadarastorage.com>,
Yair Hershko <yair@zadarastorage.com>,
xfs@oss.sgi.com
Subject: Re: xfs resize: primary superblock is not updated immediately
Date: Wed, 24 Feb 2016 09:59:26 +1100 [thread overview]
Message-ID: <20160223225926.GN25832@dastard> (raw)
In-Reply-To: <D5578D3E98EE48B88EA9A1126B671155@alyakaslap>
On Tue, Feb 23, 2016 at 02:25:38PM +0200, Alex Lyakas wrote:
> Hi Dave,
>
> Below is a detailed reproduction scenario of the problem.
Can you package this for xfstests and send to
fstests@vger.kernel.org, please?
> No
> snapshots involved, only XFS. The scenario is performed on a VM,
> running kernel 3.18.19.
And a current kernel (e.g. 4.5-rc5) behaves how?
> 9) mount
> # mount -o sync /dev/mapper/xfs_base /mnt/xfs/
>
> Kernel panics with [2].
It tried to read a buffer beyond the current end of filesystem that
log recoery knows about. Given the on-disk superblock had not been
updated by the growfs operation, this should have been detected
by _xfs_buf_find() and errored out, not tried to look up a per-ag
structure that is beyond the current end of filesystem.
i.e. the code I pointed out in my previous email failed to detect
the situation is it supposed to be protecting against. Why did that
"block beyond the end of the filesystem" detection fail?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-23 22:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3685DFAD20214109878873CF81232704@alyakaslap>
2016-02-22 21:20 ` xfs resize: primary superblock is not updated immediately Dave Chinner
2016-02-22 22:38 ` Alex Lyakas
2016-02-22 23:56 ` Dave Chinner
2016-02-23 12:25 ` Alex Lyakas
2016-02-23 22:59 ` Dave Chinner [this message]
2016-02-29 9:47 ` Alex Lyakas
2016-02-29 21:16 ` Dave Chinner
2016-03-01 7:20 ` Dave Chinner
2016-03-02 13:14 ` Fanael Linithien
2016-03-03 9:18 ` Alex Lyakas
2016-03-03 21:31 ` Dave Chinner
2016-03-06 9:46 ` Alex Lyakas
2016-03-06 15:46 ` Eric Sandeen
2016-03-06 20:49 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223225926.GN25832@dastard \
--to=david@fromorbit.com \
--cc=alex@zadarastorage.com \
--cc=danny@zadarastorage.com \
--cc=hch@infradead.org \
--cc=shyam@zadarastorage.com \
--cc=xfs@oss.sgi.com \
--cc=yair@zadarastorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox