From: Christoph Hellwig <hch@infradead.org>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: cmaiolino@redhat.com, darrick.wong@oracle.com,
namjae.jeon@samsung.com, bfoster@redhat.com, sandeen@sandeen.net,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
billodo@redhat.com
Subject: Re: [PATCH] xfs: remove impossible condition
Date: Tue, 1 Mar 2016 04:08:14 -0800 [thread overview]
Message-ID: <20160301120814.GA5217@infradead.org> (raw)
In-Reply-To: <1456404237-18169-1-git-send-email-luisbg@osg.samsung.com>
On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote:
> bp_release is set to 0 just before the breakpoint of the for loop before
> the conditional check (in line 458). The other breakpoint is a goto that
> skips the dead code.
Yes, this looks correct:
Reviewed-by: Christoph Hellwig <hch@lst.de>
The whole code around this is rather grotty and could use some more
work, though..
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-01 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 12:43 [PATCH] xfs: remove impossible condition Luis de Bethencourt
2016-03-01 12:08 ` Christoph Hellwig [this message]
2016-03-01 13:23 ` Luis de Bethencourt
2016-03-01 18:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301120814.GA5217@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=billodo@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=namjae.jeon@samsung.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox