From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH RFC 1/3] xfs: debug mode forced buffered write failure
Date: Tue, 1 Mar 2016 04:55:16 -0800 [thread overview]
Message-ID: <20160301125516.GB3540@infradead.org> (raw)
In-Reply-To: <1456756170-51248-2-git-send-email-bfoster@redhat.com>
On Mon, Feb 29, 2016 at 09:29:28AM -0500, Brian Foster wrote:
> Add a DEBUG mode-only sysfs knob to enable forced buffered write
> failure. An additional side effect of this mode is brute force killing
> of delayed allocation blocks in the range of the write. The latter is
> the prime motiviation behind this patch, as userspace test
> infrastructure requires a reliable mechanism to create and split
> delalloc extents without causing extent conversion.
>
> Certain fallocate operations (i.e., zero range) were used for this in
> the past, but the implementations have changed such that delalloc
> extents are flushed and converted to real blocks, rendering the test
> useless.
Looks harmless, but I'd add a inline function to check for the failed
writes field so that we can compile it away entirely for !DEBUG builds.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-01 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 14:29 [PATCH v2 0/3] fix up indlen reservations on extent split Brian Foster
2016-02-29 14:29 ` [PATCH RFC 1/3] xfs: debug mode forced buffered write failure Brian Foster
2016-03-01 12:55 ` Christoph Hellwig [this message]
2016-03-01 13:10 ` Brian Foster
2016-02-29 14:29 ` [PATCH 2/3] xfs: update icsb freeblocks counter after extent deletion Brian Foster
2016-03-01 12:48 ` Christoph Hellwig
2016-02-29 14:29 ` [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available Brian Foster
2016-03-01 13:00 ` Christoph Hellwig
2016-03-01 13:11 ` Brian Foster
2016-02-29 14:36 ` [PATCH v2 0/3] fix up indlen reservations on extent split Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301125516.GB3540@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox