From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id D60257CB3 for ; Tue, 1 Mar 2016 07:00:20 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 971168F8035 for ; Tue, 1 Mar 2016 05:00:20 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id oeZP43EAxoqHFe5n (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 01 Mar 2016 05:00:19 -0800 (PST) Date: Tue, 1 Mar 2016 05:00:18 -0800 From: Christoph Hellwig Subject: Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available Message-ID: <20160301130018.GA28675@infradead.org> References: <1456756170-51248-1-git-send-email-bfoster@redhat.com> <1456756170-51248-4-git-send-email-bfoster@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1456756170-51248-4-git-send-email-bfoster@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: xfs@oss.sgi.com I've been wrapping my head around this since yersterday.. It looks reasonable, but I'd be much more comfortable if you could split this into two patches: - one to just factor out a helper to update the temp and temp2 values (great variable names while we're at it.. not your fault, though) - one to actually change the algorithm used. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs