From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, xfs@oss.sgi.com
Subject: Re: ASSERT in xlog_find_verify_log_record during xfs/098
Date: Tue, 1 Mar 2016 12:45:38 -0800 [thread overview]
Message-ID: <20160301204538.GA6371@infradead.org> (raw)
In-Reply-To: <56D5E7DA.3080900@redhat.com>
On Tue, Mar 01, 2016 at 01:04:58PM -0600, Eric Sandeen wrote:
> Should that assert even be there? Looks like it's gracefully
> handled, I don't see offhand that anything should have caught
> this corruption earlier, and we don't really want to bug on disk
> corruption. Am I missing something?
We used to have a couple of these, especially in log recovery - whoever
wrote this code probably though trapping on these corruptions for
a debug kernel makes sense.
I'm fine with dropping them, and a little audit for more of them
might not hurt.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-03-01 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 19:04 ASSERT in xlog_find_verify_log_record during xfs/098 Eric Sandeen
2016-03-01 20:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301204538.GA6371@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox