ASSERT in xlog_find_verify_log_record during xfs/098

Eric Sandeen
2016-03-01T19:05:08Z

Al mentioned that he hit an ASSERT during xfs/098, a log fuzzer
test, in xlog_find_verify_log_record():

for (i = (*last_blk) - 1; i >= 0; i--) {
if (i < start_blk) {
/* valid log record not found */
xfs_warn(log->l_mp,
"Log inconsistent (didn't find previous header)");
ASSERT(0);
error = -EIO;
goto out;
}

Should that assert even be there? Looks like it's gracefully
handled, I don't see offhand that anything should have caught
this corruption earlier, and we don't really want to bug on disk
corruption. Am I missing something?

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com