From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [ANNOUNCE] xfs; for-next branch updated to 31bb236
Date: Thu, 3 Mar 2016 08:09:31 +1100 [thread overview]
Message-ID: <20160302210931.GN30721@dastard> (raw)
In-Reply-To: <20160302094559.GB18130@infradead.org>
On Wed, Mar 02, 2016 at 01:45:59AM -0800, Christoph Hellwig wrote:
> > Mateusz Guzik (1):
> > [2e83b79] xfs: fix two memory leaks in xfs_attr_list.c error paths
>
> This didn't seem to address the comment about using a goto for
> error handling?
I looked at it, and there isn't a case for a goto. The allocated
memory is in a variable local to the if branch where the leak was
found. Using a jump-based error handling stack means making
all those variables global, and then having to make the freeing
of it conditional. Simply didn't seem worth it to me.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-03-02 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 23:15 [ANNOUNCE] xfs; for-next branch updated to 31bb236 Dave Chinner
2016-03-02 9:45 ` Christoph Hellwig
2016-03-02 21:09 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302210931.GN30721@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox