public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Alex Lyakas <alex@zadarastorage.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Danny Shavit <danny@zadarastorage.com>,
	xfs@oss.sgi.com
Subject: Re: xfs resize: primary superblock is not updated immediately
Date: Mon, 7 Mar 2016 07:49:38 +1100	[thread overview]
Message-ID: <20160306204938.GS30721@dastard> (raw)
In-Reply-To: <CAOcd+r1b_9yhBtaBGHeMY7eOUyp1pO=DRbq0z2B1ojyiO-8t=A@mail.gmail.com>

On Sun, Mar 06, 2016 at 11:46:58AM +0200, Alex Lyakas wrote:
> Hello Dave,
> 
> On Thu, Mar 3, 2016 at 11:31 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Thu, Mar 03, 2016 at 11:18:43AM +0200, Alex Lyakas wrote:
> >> Hello Dave,
> >> Thanks for the patch! I confirm that it fixes the scenario.
> >>
> >> At [1] please find all the blknos that are being used during the log
> >> recovery (if that's of any interest).
> > ....
> >> Mar  3 11:17:41 vc-00-00-350-dev kernel: [   68.129739]
> >> _xfs_buf_find: blkno=200705 eofs=204800 >m_sb.sb_dblocks=25600
> >> Mar  3 11:17:41 vc-00-00-350-dev kernel: [   68.129746]
> >> _xfs_buf_find: blkno=200705 eofs=204800 >m_sb.sb_dblocks=25600
> >
> > Where is the warning that this block is out of range?
> Perhaps you are being confused by the ">" mark that appears in the
> prints? This was definitely added by mistake, it appears on every
> print. I apologize for that.
> If not, then my understanding is that 200705 is still less than
> 204800, so this block number is not out of range. And since we have
> added the new pag structure, the issue is now fixed.

Sorry, I misread it as 200480, not 204800. My fault, too much to do,
brain mostly fried by other stuff. So the patch works.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2016-03-06 20:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3685DFAD20214109878873CF81232704@alyakaslap>
2016-02-22 21:20 ` xfs resize: primary superblock is not updated immediately Dave Chinner
2016-02-22 22:38   ` Alex Lyakas
2016-02-22 23:56     ` Dave Chinner
2016-02-23 12:25       ` Alex Lyakas
2016-02-23 22:59         ` Dave Chinner
2016-02-29  9:47           ` Alex Lyakas
2016-02-29 21:16             ` Dave Chinner
2016-03-01  7:20               ` Dave Chinner
2016-03-02 13:14                 ` Fanael Linithien
2016-03-03  9:18                 ` Alex Lyakas
2016-03-03 21:31                   ` Dave Chinner
2016-03-06  9:46                     ` Alex Lyakas
2016-03-06 15:46                       ` Eric Sandeen
2016-03-06 20:49                       ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160306204938.GS30721@dastard \
    --to=david@fromorbit.com \
    --cc=alex@zadarastorage.com \
    --cc=danny@zadarastorage.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox