public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/259: disable CRC if testing with 512 bytes block size
Date: Mon, 7 Mar 2016 11:04:44 +0800	[thread overview]
Message-ID: <20160307030444.GA11419@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160305204517.GA10065@infradead.org>

On Sat, Mar 05, 2016 at 12:45:17PM -0800, Christoph Hellwig wrote:
> This will force crcs off for all the blocksizes.  We should
> either always skip 512 bytes, or disable crcs only for the 512 byte
> inode size case.  The first seems either, but the second would give
> better test coverage.

Thanks for the review! I think the test itself has already disabled crc
for 512 block size fs, and this patch disables crc only if the TEST_DEV
has no crc, so it just fixes a corner case in this crc detecting, and
doesn't reduce the test coverage.

Thanks,
Eryu

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2016-03-07  3:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 16:51 [PATCH] xfs/259: disable CRC if testing with 512 bytes block size Eryu Guan
2016-03-05 20:45 ` Christoph Hellwig
2016-03-07  3:04   ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307030444.GA11419@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox