From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>, darrick.wong@oracle.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/6] xfs: ioends require logically contiguous file offsets
Date: Mon, 7 Mar 2016 08:26:44 -0800 [thread overview]
Message-ID: <20160307162644.GB19784@infradead.org> (raw)
In-Reply-To: <1457300990-18300-3-git-send-email-david@fromorbit.com>
On Mon, Mar 07, 2016 at 08:49:46AM +1100, Dave Chinner wrote:
> From: "Darrick J. Wong" <darrick.wong@oracle.com>
>
> We need to create a new ioend if the current writepage call isn't
> logically contiguous with the range contained in the previous ioend.
> Hopefully writepage gets called in order of increasing file offset.
This looks reasonable, but how did we manage to get away without this for
so long? I think as-is we do not actually require it - for setting
i_size we just care about the highest offset, and for unwritten extent
conversion we just need the lowest and highest offset, and we were
making use of that fact in direct I/O extensively before I rewrote that
code not to use ioends.
So this looks fine to me, but the description could use some better
wording.
Signed-off-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-07 16:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 21:49 [PATCH 0/6] xfs: accumulated fixes for 4.6 Dave Chinner
2016-03-06 21:49 ` [PATCH 1/6] xfs: reinitialise per-AG structures if geometry changes during recovery Dave Chinner
2016-03-07 16:24 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 2/6] xfs: ioends require logically contiguous file offsets Dave Chinner
2016-03-07 16:26 ` Christoph Hellwig [this message]
2016-03-08 2:33 ` Darrick J. Wong
2016-03-08 7:01 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 3/6] xfs: fix computation of inode btree maxlevels Dave Chinner
2016-03-06 21:49 ` [PATCH 4/6] xfs: use named array initializers for log item dumping Dave Chinner
2016-03-07 16:27 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 5/6] xfs: check sizes of XFS on-disk structures at compile time Dave Chinner
2016-03-07 16:27 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 6/6] xfs: pad xfs_attr_leaf_name_remote to avoid tripping on m68k Dave Chinner
2016-03-07 16:28 ` Christoph Hellwig
2016-03-08 3:56 ` Dave Chinner
2016-03-08 7:02 ` Christoph Hellwig
2016-03-08 17:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307162644.GB19784@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox