From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 6/6] xfs: pad xfs_attr_leaf_name_remote to avoid tripping on m68k
Date: Mon, 7 Mar 2016 23:02:08 -0800 [thread overview]
Message-ID: <20160308070208.GB30440@infradead.org> (raw)
In-Reply-To: <20160308035648.GV30721@dastard>
On Tue, Mar 08, 2016 at 02:56:48PM +1100, Dave Chinner wrote:
> > I think using a small fixed size array as a variable sized array
> > is not a good idea, especially with increasinly "smart" optimizing
> > compilers. I'd rather take this structure out the size checking,
> > and then move it to a C99 VLA instead of the size 1 hack in the long
> > run.
>
> I don't have the time right now to do this, so I'm just going to
> drop it - I'd guess the overlap between m68k and XFS users is so
> close to zero that it just doesn't matter. I'll just drop this
> patch for now.
I'll send you a patch for it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-08 7:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 21:49 [PATCH 0/6] xfs: accumulated fixes for 4.6 Dave Chinner
2016-03-06 21:49 ` [PATCH 1/6] xfs: reinitialise per-AG structures if geometry changes during recovery Dave Chinner
2016-03-07 16:24 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 2/6] xfs: ioends require logically contiguous file offsets Dave Chinner
2016-03-07 16:26 ` Christoph Hellwig
2016-03-08 2:33 ` Darrick J. Wong
2016-03-08 7:01 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 3/6] xfs: fix computation of inode btree maxlevels Dave Chinner
2016-03-06 21:49 ` [PATCH 4/6] xfs: use named array initializers for log item dumping Dave Chinner
2016-03-07 16:27 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 5/6] xfs: check sizes of XFS on-disk structures at compile time Dave Chinner
2016-03-07 16:27 ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 6/6] xfs: pad xfs_attr_leaf_name_remote to avoid tripping on m68k Dave Chinner
2016-03-07 16:28 ` Christoph Hellwig
2016-03-08 3:56 ` Dave Chinner
2016-03-08 7:02 ` Christoph Hellwig [this message]
2016-03-08 17:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308070208.GB30440@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox