From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/16] xfs: first part of rmapbt functionality
Date: Fri, 11 Mar 2016 08:44:32 +1100 [thread overview]
Message-ID: <20160310214432.GX30721@dastard> (raw)
In-Reply-To: <20160310141434.GA29058@infradead.org>
On Thu, Mar 10, 2016 at 06:14:34AM -0800, Christoph Hellwig wrote:
> On Tue, Mar 08, 2016 at 03:16:02PM +1100, Dave Chinner wrote:
> > This isn't all of the rmap functionality. It's patches up to the
> > point where I've come across the first piece that needs to be
> > reworked (the rmap intent execution code), so there's no point
> > holding these back until I've sorted that out. This builds on top of
> > for-next and the patch set I posted yesterday.
> >
> > Darrick, I've changed the authorship of the patches to reflect
> > the original series this has come from - can you check to see if
> > there's anything I got wrong when I did that?
>
> I'll come some minor bits on the actual patches, but I'd like to
> understand a few fundamental things first:
>
> For one Darrick has introduced a new rmapxbt btree recently, which
> allows using a rmap on reflink enabled file systems. In his tree
> we thus have two different implementation of a reverse mapping
> btree. Is there any good reason to keep it this way? For one
> reflinks are a compelling feature that I doubt people want to
> disable in the long run, so most filesystem will be using rmapxbt.
> I also don't think having these two implementations is good for the
> testing matrix in the long run.
I haven't got as far as the rmapxbt code yet - it's currently at the
end of the entire series, and I'm trying to sort out problems in
infrastructure right now (i.e. rmapbt modifications are atomic and
crash safe w.r.t. bmapbt changes and EFI processing).
I'm planning on re-ordering the rmapxbt and interval query tree
stuff to before the reflink code is included, but I haven't got
hatfar yet so I haven't looked at the code yet. It's slow going, and
right now I don't think I'm going to have even a complete rmapbt
series done in time for the merge 4.6 merge window, let alone all
the extra stuff Darrick has done.
So with only a couple of days left before the merge window opens, I
think this all needs to slip to the next merge window while we sort
out what disk format we are going to use and rework the series to
introduce only that format.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-10 21:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 4:16 [PATCH 0/16] xfs: first part of rmapbt functionality Dave Chinner
2016-03-08 4:16 ` [PATCH 01/16] xfs: introduce rmap btree definitions Dave Chinner
2016-03-08 4:16 ` [PATCH 02/16] xfs: add rmap btree stats infrastructure Dave Chinner
2016-03-08 4:16 ` [PATCH 03/16] xfs: rmap btree add more reserved blocks Dave Chinner
2016-03-10 14:16 ` Christoph Hellwig
2016-03-10 14:22 ` Christoph Hellwig
2016-03-10 22:09 ` Dave Chinner
2016-03-11 7:32 ` Christoph Hellwig
2016-03-08 4:16 ` [PATCH 04/16] libxfs: rearrange xfs_bmap_add_free parameters Dave Chinner
2016-03-08 17:18 ` Christoph Hellwig
2016-03-08 4:16 ` [PATCH 05/16] xfs: add owner field to extent allocation and freeing Dave Chinner
2016-03-10 14:19 ` Christoph Hellwig
2016-03-28 22:05 ` Darrick J. Wong
2016-03-08 4:16 ` [PATCH 06/16] xfs: introduce rmap extent operation stubs Dave Chinner
2016-03-08 4:16 ` [PATCH 07/16] xfs: define the on-disk rmap btree format Dave Chinner
2016-03-08 4:16 ` [PATCH 08/16] xfs: add rmap btree growfs support Dave Chinner
2016-03-08 4:16 ` [PATCH 09/16] xfs: rmap btree transaction reservations Dave Chinner
2016-03-08 4:16 ` [PATCH 10/16] xfs: rmap btree requires more reserved free space Dave Chinner
2016-03-08 4:16 ` [PATCH 11/16] xfs: add rmap btree operations Dave Chinner
2016-03-08 4:16 ` [PATCH 12/16] xfs: add tracepoints for the rmap-mirrors-bmbt functions Dave Chinner
2016-03-08 4:16 ` [PATCH 13/16] xfs: add an extent to the rmap btree Dave Chinner
2016-03-08 4:16 ` [PATCH 14/16] xfs: remove an extent from " Dave Chinner
2016-03-08 4:16 ` [PATCH 15/16] xfs: add rmap btree insert and delete helpers Dave Chinner
2016-03-08 4:16 ` [PATCH 16/16] xfs: piggyback rmapbt update intents in the bmap free structure Dave Chinner
2016-04-11 23:23 ` Darrick J. Wong
2016-03-10 14:14 ` [PATCH 0/16] xfs: first part of rmapbt functionality Christoph Hellwig
2016-03-10 16:57 ` Darrick J. Wong
2016-03-10 21:44 ` Dave Chinner [this message]
2016-03-25 23:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310214432.GX30721@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox