From: Eryu Guan <eguan@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/073: filter out finobt warning from mkfs.xfs
Date: Wed, 16 Mar 2016 22:54:18 +0800 [thread overview]
Message-ID: <20160316145418.GT11419@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160316120416.GA18030@infradead.org>
On Wed, Mar 16, 2016 at 05:04:16AM -0700, Christoph Hellwig wrote:
> On Wed, Mar 16, 2016 at 07:53:24PM +0800, Eryu Guan wrote:
> > When testing xfs/073 with MKFS_OPTIONS="-m crc=1,finobt=1" set, it fails
> > due to extra warning about disabling finobt feature:
> >
> > +warning: finobt not supported without CRC support, disabled.
> >
> > Because xfs/073 disables crc unconditionally and finobt can not be
> > enabled either.
>
> How about explicitly disabling finobt as well?
I think that's a cleaner way to fix it. Just that some extra work is
needed to let the test pass with old mkfs.xfs without metadata suport.
Will send v2 shortly. Thanks for the review!
Eryu
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-16 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 11:53 [PATCH] xfs/073: filter out finobt warning from mkfs.xfs Eryu Guan
2016-03-16 12:04 ` Christoph Hellwig
2016-03-16 14:54 ` Eryu Guan [this message]
2016-03-16 20:00 ` Dave Chinner
2016-03-17 3:28 ` Eryu Guan
2016-03-16 15:04 ` [PATCH v2] xfs/073: avoid finobt warning from mkfs Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316145418.GT11419@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox