From: Eryu Guan <eguan@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/073: filter out finobt warning from mkfs.xfs
Date: Thu, 17 Mar 2016 11:28:02 +0800 [thread overview]
Message-ID: <20160317032801.GU11419@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160316200043.GG11812@dastard>
On Thu, Mar 17, 2016 at 07:00:43AM +1100, Dave Chinner wrote:
> On Wed, Mar 16, 2016 at 10:54:18PM +0800, Eryu Guan wrote:
> > On Wed, Mar 16, 2016 at 05:04:16AM -0700, Christoph Hellwig wrote:
> > > On Wed, Mar 16, 2016 at 07:53:24PM +0800, Eryu Guan wrote:
> > > > When testing xfs/073 with MKFS_OPTIONS="-m crc=1,finobt=1" set, it fails
> > > > due to extra warning about disabling finobt feature:
> > > >
> > > > +warning: finobt not supported without CRC support, disabled.
> > > >
> > > > Because xfs/073 disables crc unconditionally and finobt can not be
> > > > enabled either.
> > >
> > > How about explicitly disabling finobt as well?
> >
> > I think that's a cleaner way to fix it. Just that some extra work is
> > needed to let the test pass with old mkfs.xfs without metadata suport.
>
> This is a downhill slope. e.g. if I add "-i sparse=1" to the mkfs
> line, it will warning differently and a new filter is needed. I
> would suggest just ignoring the mkfs output altogether (maybe just
> dumping it all to $seqres.full) as it's not necessary to determine
> whether the test ran correctly or not.
Yes, other tests that call _scratch_mkfs_xfs with explicit "-m crc=0"
all redirect output to null or $seqres.full, so I only see the warning
in xfs/073. I'd like to do the same for it.
I think the update to _scratch_mkfs_xfs_opts() in v2 patch is still
worth doing, it belongs to a seperate patch though.
Thanks,
Eryu
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-17 3:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 11:53 [PATCH] xfs/073: filter out finobt warning from mkfs.xfs Eryu Guan
2016-03-16 12:04 ` Christoph Hellwig
2016-03-16 14:54 ` Eryu Guan
2016-03-16 20:00 ` Dave Chinner
2016-03-17 3:28 ` Eryu Guan [this message]
2016-03-16 15:04 ` [PATCH v2] xfs/073: avoid finobt warning from mkfs Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317032801.GU11419@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox