From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfs: set up inode operation vectors later
Date: Thu, 24 Mar 2016 00:26:30 +0100 [thread overview]
Message-ID: <20160323232630.GA5646@lst.de> (raw)
In-Reply-To: <20160323230500.GZ30721@dastard>
On Thu, Mar 24, 2016 at 10:05:00AM +1100, Dave Chinner wrote:
> > d_instantiate(dentry, inode);
> > xfs_finish_inode_setup(cip);
>
> I think there are more places than this that need xfs_setup_iops()
> calls - a quick look around makes me think they need to be paired
> with every path that calls xfs_finish_inode_setup().
Most calls to xfs_finish_inode_setup are for error cases that
just drop the inode instantly and don't need it. The other
cases are:
- xfs_generic_create, xfs_vn_symlink and xfs_setup_existing_inode,
which are handled in this patch
- xfs_qm_qino_alloc, which is for the quota inode that doesn't have
inode operations
- xfs_rename_alloc_whiteout which probably needs it. This seems
to be recent and has no apparent test coverage, so I'm not sure
how to verify it, though.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-23 23:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:48 support RCU lookups for inline symlinks Christoph Hellwig
2016-03-23 13:48 ` [PATCH 1/4] xfs: factor out a helper to initialize a local format inode fork Christoph Hellwig
2016-03-23 13:48 ` [PATCH 2/4] xfs: set up inode operation vectors later Christoph Hellwig
2016-03-23 23:05 ` Dave Chinner
2016-03-23 23:26 ` Christoph Hellwig [this message]
2016-03-23 23:45 ` Dave Chinner
2016-03-23 13:48 ` [PATCH 3/4] xfs: use ->readlink to implement the readlink_by_handle ioctl Christoph Hellwig
2016-03-23 13:48 ` [PATCH 4/4] xfs: optimize inline symlinks Christoph Hellwig
2016-04-05 21:55 ` support RCU lookups for " Dave Chinner
2016-04-07 23:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323232630.GA5646@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox