From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <guaneryu@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: mute some sparse warnings
Date: Fri, 25 Mar 2016 11:07:19 -0700 [thread overview]
Message-ID: <20160325180719.GA4500@infradead.org> (raw)
In-Reply-To: <1458929042-23991-1-git-send-email-guaneryu@gmail.com>
> @@ -478,7 +478,8 @@ xfs_inode_item_unpin(
> STATIC uint
> xfs_inode_item_push(
> struct xfs_log_item *lip,
> - struct list_head *buffer_list)
> + struct list_head *buffer_list) __releases(&lip->li_ailp->xa_lock)
> + __acquires(&lip->li_ailp->xa_lock)
Can you move these down a bit? Something like:
struct list_head *buffer_list)
__releases(&lip->li_ailp->xa_lock)
__acquires(&lip->li_ailp->xa_lock)
{
?
Otherwise looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-25 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 18:04 [PATCH] xfs: mute some sparse warnings Eryu Guan
2016-03-25 18:07 ` Christoph Hellwig [this message]
2016-03-27 4:28 ` [PATCH v2] " Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325180719.GA4500@infradead.org \
--to=hch@infradead.org \
--cc=guaneryu@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox