From: Dave Chinner <david@fromorbit.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-sh list <linux-sh@vger.kernel.org>,
Rich Felker <dalias@libc.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Cris <linux-cris-kernel@axis.com>,
xfs@oss.sgi.com
Subject: Re: Build regressions/improvements in v4.6-rc1
Date: Tue, 29 Mar 2016 08:59:23 +1100 [thread overview]
Message-ID: <20160328215923.GG11812@dastard> (raw)
In-Reply-To: <CAMuHMdW3dfhZVT0e4tiqsbEPjYYA_hGUXQer1bQDeF2Gbs4WJg@mail.gmail.com>
On Sun, Mar 27, 2016 at 02:43:24PM +0200, Geert Uytterhoeven wrote:
> On Sun, Mar 27, 2016 at 2:39 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v4.6-rc1[1] compared to v4.5[2].
> >
> > Summarized:
> > - build errors: +9/-6
>
> > [1] http://kisskb.ellerman.id.au/kisskb/head/10114/ (all 262 configs)
> > [2] http://kisskb.ellerman.id.au/kisskb/head/10047/ (all 262 configs)
>
> > 9 error regressions:
> > + /home/kisskb/slave/src/fs/xfs/xfs_ondisk.h: error: call to
> > '__compiletime_assert_79' declared with attribute error: XFS:
> > sizeof(xfs_attr_shortform_t) is wrong, expected 8: => 79:2
>
> cris-allyesconfig, cris-allmodconfig
Yup, cris is the only platform that throws this error on this
structure. It's an on-disk structure and relying on the gcc
optimiser to do the same thing from release to release has become
such a crap-shoot these days. Hence as a stop-gap measure we added
build time checking of what they compiler is doing with those
structures, and to refuse to build XFS if the compiler/platform is
doing something obviously different.
Modernising the on-disk structure definitions is on the list of
things to do, but it's nowhere near the top of my list at the
moment...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-28 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMuHMdXx80zs5VoA_aYc_wMn37O=fa6oXk-ovteHq0hGQYUUzg@mail.gmail.com>
2016-03-27 12:43 ` Build regressions/improvements in v4.6-rc1 Geert Uytterhoeven
2016-03-27 13:15 ` Rich Felker
2016-03-28 21:59 ` Dave Chinner [this message]
2016-03-28 22:47 ` Darrick J. Wong
2016-03-29 6:16 ` Mikael Starvik
2016-03-29 6:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328215923.GG11812@dastard \
--to=david@fromorbit.com \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox