Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h

Ming Lei
2016-03-29T08:53:28Z

On Tue, Mar 29, 2016 at 3:26 PM, Christoph Hellwig <hch@infradead.org> wrote:
>> --- a/include/linux/bio.h
>> +++ b/include/linux/bio.h
>> @@ -31,6 +31,7 @@
>>
>> /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */
>> #include <linux/blk_types.h>
>> +#include <linux/bvec_iter.h>
>>
>> #define BIO_DEBUG
>>
>> @@ -40,10 +41,6 @@
>> #define BIO_BUG_ON
>> #endif
>>
>> -#define BIO_MAX_PAGES 256
>> -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT)
>> -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9)
>
> I see no reason why these should be moved out of bio.h.

You are right, these should be kept in bio.h.

Thanks for your review!

>
> Otherwise this looks fine to me.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html