Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h

Christoph Hellwig
2016-03-29T07:26:27Z

> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -31,6 +31,7 @@
>
> /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */
> #include <linux/blk_types.h>
> +#include <linux/bvec_iter.h>
>
> #define BIO_DEBUG
>
> @@ -40,10 +41,6 @@
> #define BIO_BUG_ON
> #endif
>
> -#define BIO_MAX_PAGES 256
> -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT)
> -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9)

I see no reason why these should be moved out of bio.h.

Otherwise this looks fine to me.