From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Jens Axboe <axboe@fb.com>, Boaz Harrosh <boaz@plexistor.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Anton Altaparmakov <anton@tuxera.com>,
drbd-dev@lists.linbit.com
Subject: Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK
Date: Wed, 30 Mar 2016 10:19:27 -0700 [thread overview]
Message-ID: <20160330171927.GA13320@infradead.org> (raw)
In-Reply-To: <1459354637-17415-3-git-send-email-ming.lei@canonical.com>
On Thu, Mar 31, 2016 at 12:17:11AM +0800, Ming Lei wrote:
> We will use bvec iterator to implement iterate_bvec(): lib/iov_iter.c.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
> include/linux/blk_types.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 86a38ea..fd8527b 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -26,8 +26,6 @@ struct bio_vec {
> unsigned int bv_offset;
> };
>
> -#ifdef CONFIG_BLOCK
> -
> struct bvec_iter {
> sector_t bi_sector; /* device address in 512 byte
> sectors */
> @@ -39,6 +37,8 @@ struct bvec_iter {
> current bvec */
> };
I didn't catch this earlier, but shouldn't this also move to
bvec_iter.h? Or maybe just create a linux/bvec.h for the bvec, bvec_iter
and bvec iter macros given that those are the types used outside the
block layer as well.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-30 17:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 16:17 [PATCH v1 0/8] block: prepare for multipage bvecs Ming Lei
2016-03-30 16:17 ` [PATCH v1 1/8] block: move bvec iterator into include/linux/bvec_iter.h Ming Lei
2016-03-30 16:17 ` [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei
2016-03-30 17:19 ` Christoph Hellwig [this message]
2016-03-31 1:02 ` Ming Lei
2016-03-31 7:52 ` Christoph Hellwig
2016-04-01 0:31 ` Ming Lei
2016-03-30 16:17 ` [PATCH v1 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei
2016-03-30 16:17 ` [PATCH v1 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei
2016-03-30 16:17 ` [PATCH v1 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei
2016-03-30 16:17 ` [PATCH v1 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei
2016-03-30 16:17 ` [PATCH v1 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei
2016-03-30 16:17 ` [PATCH v1 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330171927.GA13320@infradead.org \
--to=hch@infradead.org \
--cc=anton@tuxera.com \
--cc=axboe@fb.com \
--cc=boaz@plexistor.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=philipp.reisner@linbit.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox