public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't hand out pNFS layouts for reflink inodes
Date: Wed, 30 Mar 2016 19:26:34 +0200	[thread overview]
Message-ID: <20160330172634.GA22951@lst.de> (raw)
In-Reply-To: <20160330000842.GD5822@birch.djwong.org>

On Tue, Mar 29, 2016 at 05:08:42PM -0700, Darrick J. Wong wrote:
> > Btw, we'll need something similar to prevent swapfiles which just use
> > ->bmap, but unfortunately swap just checks for the existences of method,
> > so I'll probably have to do some VFS changes to properly support that.
> 
> Yes, please.  ocfs2 will gladly let you call swapon on a reflinked file,
> and totally fails to CoW it properly. :)

Ouch.  Time to add a test for that to xfstests..

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-03-30 17:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 16:34 [PATCH] xfs: don't hand out pNFS layouts for reflink inodes Christoph Hellwig
2016-03-28 19:51 ` Darrick J. Wong
2016-03-29  7:21   ` Christoph Hellwig
2016-03-30  0:08     ` Darrick J. Wong
2016-03-30 17:26       ` Christoph Hellwig [this message]
2016-03-30 17:40         ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330172634.GA22951@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox