From: Eryu Guan <eguan@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: darrick.wong@oracle.com, fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/030: link .out file according to reflink support status
Date: Thu, 31 Mar 2016 13:56:59 +0800 [thread overview]
Message-ID: <20160331055658.GK19986@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160331042644.GK30721@dastard>
On Thu, Mar 31, 2016 at 03:26:44PM +1100, Dave Chinner wrote:
> On Wed, Mar 30, 2016 at 05:57:41PM +0800, Eryu Guan wrote:
> > Commit 31f48569c353 ("xfs/030: fix output on newer filesystems") added
> > more lines to .out file to match the output from XFS with reflink
> > support, but it broke test on older XFS.
> >
> > Fix it by introducing new .out file 030.out.reflink.linux to match the
> > reflink case, so old XFS still compares .out file against 030.out.linux.
> >
> > In order to do this, a new helper is introduced, _fs_has_reflink()
> > accepts mount point as argument and returns if the underlying fs
> > supports reflink or not.
>
> Let's not go down this path. This is a filtering issue, not a
> problem we solve by playing "let's add a golden image file for every
> different filesystem format we can create".
>
> The problem here is that reflink triggers a change in the initial
> population of the AGFL - from 4 blocks to 6 blocks, and so repair
> warns 6 times instead of 4. After filtering, that gives 6 indentical
> output lines instead of 4.
>
> Doing something as simple as collapsing repeated identical lines
> (e.g filtering through uniq) will work for all filesystem formats
> and any future changes that modify the initial AGFL population...
I thought about filtering at first, but didn't find a way to filter out
the extra two lines easily. Collapsing repeaded lines into one will do.
I'll send out v2 shortly. Thanks for reviewing!
Eryu
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-31 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 9:57 [PATCH] xfs/030: link .out file according to reflink support status Eryu Guan
2016-03-30 17:24 ` Darrick J. Wong
2016-03-31 4:26 ` Dave Chinner
2016-03-31 5:56 ` Eryu Guan [this message]
2016-03-31 6:11 ` [PATCH v2] xfs/030: filter out repeated lines from .out files Eryu Guan
2016-03-31 7:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331055658.GK19986@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox