From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7BC637CA3 for ; Thu, 31 Mar 2016 00:57:06 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 33E148F8037 for ; Wed, 30 Mar 2016 22:57:02 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id h8V3Ira3sUxBD1dO (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 30 Mar 2016 22:57:02 -0700 (PDT) Date: Thu, 31 Mar 2016 13:56:59 +0800 From: Eryu Guan Subject: Re: [PATCH] xfs/030: link .out file according to reflink support status Message-ID: <20160331055658.GK19986@eguan.usersys.redhat.com> References: <1459331861-15025-1-git-send-email-eguan@redhat.com> <20160331042644.GK30721@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160331042644.GK30721@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: darrick.wong@oracle.com, fstests@vger.kernel.org, xfs@oss.sgi.com On Thu, Mar 31, 2016 at 03:26:44PM +1100, Dave Chinner wrote: > On Wed, Mar 30, 2016 at 05:57:41PM +0800, Eryu Guan wrote: > > Commit 31f48569c353 ("xfs/030: fix output on newer filesystems") added > > more lines to .out file to match the output from XFS with reflink > > support, but it broke test on older XFS. > > > > Fix it by introducing new .out file 030.out.reflink.linux to match the > > reflink case, so old XFS still compares .out file against 030.out.linux. > > > > In order to do this, a new helper is introduced, _fs_has_reflink() > > accepts mount point as argument and returns if the underlying fs > > supports reflink or not. > > Let's not go down this path. This is a filtering issue, not a > problem we solve by playing "let's add a golden image file for every > different filesystem format we can create". > > The problem here is that reflink triggers a change in the initial > population of the AGFL - from 4 blocks to 6 blocks, and so repair > warns 6 times instead of 4. After filtering, that gives 6 indentical > output lines instead of 4. > > Doing something as simple as collapsing repeated identical lines > (e.g filtering through uniq) will work for all filesystem formats > and any future changes that modify the initial AGFL population... I thought about filtering at first, but didn't find a way to filter out the extra two lines easily. Collapsing repeaded lines into one will do. I'll send out v2 shortly. Thanks for reviewing! Eryu _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs