From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 95DC27CA3 for ; Thu, 31 Mar 2016 09:53:01 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 59AD28F8050 for ; Thu, 31 Mar 2016 07:52:58 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 2pqkiBwQFfGy59g0 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 31 Mar 2016 07:52:57 -0700 (PDT) Date: Thu, 31 Mar 2016 10:52:54 -0400 From: Brian Foster Subject: Re: [PATCH] xfs: add missing break in xfs_parseargs() Message-ID: <20160331145254.GB10474@bfoster.bfoster> References: <1459415583-26981-1-git-send-email-guaneryu@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1459415583-26981-1-git-send-email-guaneryu@gmail.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eryu Guan Cc: esandeen@redhat.com, xfs@oss.sgi.com On Thu, Mar 31, 2016 at 05:13:03PM +0800, Eryu Guan wrote: > Commit 2e74af0e1189 ("xfs: convert mount option parsing to tokens") > missed a 'break;' in xfs_parseargs() which causes mount to fail with > "-o pqnoenforce" option. xfs/050 catches this failure. > > XFS (vda6): Super block does not support project and group quota together > > Fixes: 2e74af0e1189 ("xfs: convert mount option parsing to tokens") > Signed-off-by: Eryu Guan > --- Reviewed-by: Brian Foster > fs/xfs/xfs_super.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index d760934..361564e 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -350,6 +350,7 @@ xfs_parseargs( > case Opt_pqnoenforce: > mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE); > mp->m_qflags &= ~XFS_PQUOTA_ENFD; > + break; > case Opt_gquota: > case Opt_grpquota: > mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE | > -- > 2.5.5 > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs