public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Avi Kivity <avi@scylladb.com>
Cc: xfs@oss.sgi.com
Subject: Re: Internal error at xfs_trans_cancel
Date: Fri, 1 Apr 2016 09:01:05 +1100	[thread overview]
Message-ID: <20160331220105.GQ11812@dastard> (raw)
In-Reply-To: <56FD513B.40805@scylladb.com>

On Thu, Mar 31, 2016 at 07:32:59PM +0300, Avi Kivity wrote:
> Saw this nice gift this morning:
> 
> [2121372.825904] XFS (dm-10): Internal error xfs_trans_cancel at
> line 1007 of file fs/xfs/xfs_trans.c.  Caller xfs_create+0x40e/0x710
> [xfs]
> [2121372.827209] CPU: 0 PID: 32020 Comm: java Tainted: G W
> ------------   3.10.0-327.10.1.el7.x86_64 #1
> [2121372.828529] Hardware name:                  /DH77EB, BIOS
> EBH7710H.86A.0099.2013.0125.1400 01/25/2013
> [2121372.829873]  ffff8807b2b11e80 00000000470753cc ffff88031058bb48
> ffffffff816352cc
> [2121372.831232]  ffff88031058bb60 ffffffffa084be5b ffffffffa085b7ee
> ffff88031058bb88
> [2121372.832542]  ffffffffa0866909 ffff88014a2f3b80 ffff8807f29a2800
> 0000000000000000
> [2121372.833850] Call Trace:
> [2121372.835125]  [<ffffffff816352cc>] dump_stack+0x19/0x1b
> [2121372.836397]  [<ffffffffa084be5b>] xfs_error_report+0x3b/0x40 [xfs]
> [2121372.837654]  [<ffffffffa085b7ee>] ? xfs_create+0x40e/0x710 [xfs]
> [2121372.838915]  [<ffffffffa0866909>] xfs_trans_cancel+0xd9/0x100 [xfs]
> [2121372.840178]  [<ffffffffa085b7ee>] xfs_create+0x40e/0x710 [xfs]
> [2121372.841444]  [<ffffffffa0857d8b>] xfs_vn_mknod+0xbb/0x250 [xfs]
> [2121372.842683]  [<ffffffffa0857f53>] xfs_vn_create+0x13/0x20 [xfs]
> [2121372.843887]  [<ffffffff811eacdd>] vfs_create+0xcd/0x130
> [2121372.845103]  [<ffffffff811ec36f>] do_last+0xbef/0x1270
> [2121372.846324]  [<ffffffff811ee6d2>] path_openat+0xc2/0x490
> [2121372.847538]  [<ffffffff811efda2>] ? user_path_at_empty+0x72/0xc0
> [2121372.848746]  [<ffffffff811efe9b>] do_filp_open+0x4b/0xb0
> [2121372.849917]  [<ffffffff811fca27>] ? __alloc_fd+0xa7/0x130
> [2121372.851090]  [<ffffffff811dd843>] do_sys_open+0xf3/0x1f0
> [2121372.852227]  [<ffffffff811dd95e>] SyS_open+0x1e/0x20
> [2121372.853356]  [<ffffffff81645a49>] system_call_fastpath+0x16/0x1b
> [2121372.854486] XFS (dm-10): xfs_do_force_shutdown(0x8) called from
> line 1008 of file fs/xfs/xfs_trans.c.  Return address =
> 0xffffffffa0866922
> 
> Filesystem appeared full,

ISTR there was a bug inthe inode allocation code that could lead to
multiple AGFs being dirtied (via AGFL fixups) and then not having
enough contiguous freee space to allocate a new inode chuck. I think
it was also a potential deadlock vector. Yeah:

e480a72 xfs: avoid AGI/AGF deadlock scenario for inode chunk allocation

Fixed in 3.15.

> but after a reboot (critical server) it
> went back down to 420GB free.

Lots of open unlinked (or O_TMPFILE) files, I'd guess.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-03-31 22:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 16:32 Internal error at xfs_trans_cancel Avi Kivity
2016-03-31 22:01 ` Dave Chinner [this message]
2016-04-01 18:34   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331220105.GQ11812@dastard \
    --to=david@fromorbit.com \
    --cc=avi@scylladb.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox