From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/7] fs: introduce iomap infrastructure
Date: Mon, 4 Apr 2016 17:55:14 +1000 [thread overview]
Message-ID: <20160404075514.GD11238@dastard> (raw)
In-Reply-To: <20160404071203.GA29313@lst.de>
On Mon, Apr 04, 2016 at 09:12:03AM +0200, Christoph Hellwig wrote:
> On Mon, Apr 04, 2016 at 11:47:06AM +1000, Dave Chinner wrote:
> > > Patch below fixes the issue, as well as the fact that
> > > iomap_page_mkwrite_actor() needs to return the count of bytes
> > > "written", not zero on success for iomap_write_segment() to do the
> > > right thing on multi-segment writes.
> >
> > Hmm - this fix then breaks generic/029. Christoph, can you look into
> > these issues?
>
> I've allocated some time for the series this week, I'll also add the
> iomap based fiemap implementation from the gfs2 folks while I'm at it.
Great! I've been running it here for the past week or so, and on 4k
block size filesystems it hasn't caused any regressions. I've been
running it with the straight-to-bio writeback paches for XFS as
well, and it seems to be playing nicely with that, too. The above
problems were seen independent of the witeback patch series,
though...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-04 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 21:02 [RFC] iomap infrastructure and multipage writes Christoph Hellwig
2016-03-14 21:02 ` [PATCH 1/7] fs: move struct iomap from exportfs.h to a separate header Christoph Hellwig
2016-03-14 21:02 ` [PATCH 2/7] fs: introduce iomap infrastructure Christoph Hellwig
2016-04-04 1:28 ` Dave Chinner
2016-04-04 1:47 ` Dave Chinner
2016-04-04 7:12 ` Christoph Hellwig
2016-04-04 7:55 ` Dave Chinner [this message]
2016-03-14 21:02 ` [PATCH 3/7] xfs: make xfs_find_bdev_for_inode available outside of xfs_aops.c Christoph Hellwig
2016-03-14 21:02 ` [PATCH 4/7] xfs: make xfs_bmbt_to_iomap available outside of xfs_pnfs.c Christoph Hellwig
2016-03-14 21:02 ` [PATCH 5/7] xfs: reshuffle truncate Christoph Hellwig
2016-03-14 21:02 ` [PATCH 6/7] xfs: implement iomap based buffered write path Christoph Hellwig
2016-03-14 21:02 ` [PATCH 7/7] xfs: remove buffered write support from __xfs_get_blocks Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404075514.GD11238@dastard \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox