From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: support RCU lookups for inline symlinks
Date: Fri, 8 Apr 2016 01:21:35 +0200 [thread overview]
Message-ID: <20160407232135.GA11502@lst.de> (raw)
In-Reply-To: <20160405215508.GH11238@dastard>
On Wed, Apr 06, 2016 at 07:55:08AM +1000, Dave Chinner wrote:
> On Wed, Mar 23, 2016 at 02:48:51PM +0100, Christoph Hellwig wrote:
> > Return the inline link body in the inode to support RCU mode lookups.
>
> The series doesn't appear to cause any regressions and the code
> looks good, so I've added the missing xfs_setup_iops() call in
> xfs_rename_alloc_whiteout() (patch 2), and converted dentry->d_inode
> to d_inode(dentry) in patch 3 for consistency withe the rest of the
> code and committed this series.
Thanks. After some pondering I think we should setup the iops for the
quota inodes as well - if we ever do something like vfs_getattr on them
now that we're using VFS inode everywhere we'll need it. And I'd better
be prepared for that than finding bugs after I've forgotten about all
this. I'll send an incremental patch.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-04-07 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:48 support RCU lookups for inline symlinks Christoph Hellwig
2016-03-23 13:48 ` [PATCH 1/4] xfs: factor out a helper to initialize a local format inode fork Christoph Hellwig
2016-03-23 13:48 ` [PATCH 2/4] xfs: set up inode operation vectors later Christoph Hellwig
2016-03-23 23:05 ` Dave Chinner
2016-03-23 23:26 ` Christoph Hellwig
2016-03-23 23:45 ` Dave Chinner
2016-03-23 13:48 ` [PATCH 3/4] xfs: use ->readlink to implement the readlink_by_handle ioctl Christoph Hellwig
2016-03-23 13:48 ` [PATCH 4/4] xfs: optimize inline symlinks Christoph Hellwig
2016-04-05 21:55 ` support RCU lookups for " Dave Chinner
2016-04-07 23:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407232135.GA11502@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox