From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 940F27CB0 for ; Thu, 7 Apr 2016 18:43:20 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 548B28F8050 for ; Thu, 7 Apr 2016 16:43:20 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id kEO5ddHv28DQCxFv (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Thu, 07 Apr 2016 16:43:17 -0700 (PDT) Date: Thu, 7 Apr 2016 16:43:17 -0700 From: Christoph Hellwig Subject: Re: [PATCH 1/6] xfs: fix inode validity check in xfs_iflush_cluster Message-ID: <20160407234317.GA26634@infradead.org> References: <1460072271-23923-1-git-send-email-david@fromorbit.com> <1460072271-23923-2-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1460072271-23923-2-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Apr 08, 2016 at 09:37:46AM +1000, Dave Chinner wrote: > From: Dave Chinner > > Some careless idiot(*) wrote crap code in commit 1a3e8f3 ("xfs: > convert inode cache lookups to use RCU locking") back in late 2010, > and so xfs_iflush_cluster checks the wrong inode for whether it is > still valid under RCU protection. Fix it to lock and check the > correct inode. Looks fine, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs